Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fw+vendor package for vayu fails to flash inconsistently without utilizing dynamic_partitions_op_list #24

Closed
kamild1996 opened this issue May 29, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@kamild1996
Copy link

The firmware + vendor package generated by the tool comes with an untouched dynamic_partitions_op_list, and with the reference to that file removed from the updater-script. Such a file is troublesome to flash, as depending on the currently present MIUI ROM on the device, it either requires two attempts to flash, or constantly fails to flash. Recovery log file from the flashing process: https://gist.github.com/kamild1996/a0db92ba4b1704d6bca95c68b1adbb7f

After some experimentation I found out that:

  • modifying the dynamic_partitions_op_list file to only include the "resize vendor" line
  • adding the assert(update_dynamic_partitions(package_extract_file("dynamic_partitions_op_list"))); line back to the updater-script

allows the package to flash successfully regardless of the MIUI ROM currently present on the device.

@yshalsager yshalsager added the bug Something isn't working label Jun 1, 2021
@yshalsager
Copy link
Member

Thanks for your experimentation. Indeed the tool modifies dynamic_partitions_op_list, but seems I forgot to include it previously. Just fixed it in V2.2.2 with commit 022ce9c

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants