Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FXML-4414] Implement leftover variants of cmpf #163

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

cferry-AMD
Copy link
Collaborator

No description provided.

Copy link

@TinaAMD TinaAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mgehre-amd mgehre-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@josel-amd josel-amd self-requested a review April 15, 2024 09:18
Restrict "cmpf [true|false]" code to only allow returning i1 and nothing else.
@cferry-AMD
Copy link
Collaborator Author

@josel-amd , I let you merge this when you think it's ready :)

@josel-amd josel-amd merged commit b1eb021 into feature/fused-ops Apr 15, 2024
4 checks passed
@josel-amd josel-amd deleted the corentin.cmpf branch April 15, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants