[FXML-4440] Introduce a pass that annotates the type of the argument as an attribute #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgehre-amd
reviewed
Apr 18, 2024
mgehre-amd
reviewed
Apr 18, 2024
mgehre-amd
reviewed
Apr 18, 2024
|
We will also need to remember the types of the function results. To that end, we might need to find a more generic name of this pass, maybe something like |
cferry-AMD
reviewed
Apr 18, 2024
There was a problem hiding this comment.
Good idea! Like @mgehre-amd said, we should also save the return types.
josel-amd
force-pushed
the
jose.FXML-4440
branch
from
53a2001 to
b92bee1
Compare
mgehre-amd
reviewed
Apr 18, 2024
mgehre-amd
approved these changes
Apr 18, 2024
TinaAMD
reviewed
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a pass that annotates all func op inputs with their type as attributes.