Fix bug where emitc constants wouldn't be directly emitted in subscripts. #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmendesp-amd
commented
Dec 10, 2024
mgehre-amd
reviewed
Dec 10, 2024
|
Beyond the subscript expression, is there any other use of |
mgehre-amd
reviewed
Dec 11, 2024
…nces are emited in the cpp code.
josel-amd
reviewed
Dec 11, 2024
josel-amd
reviewed
Dec 11, 2024
…e references are emited in the cpp code." This reverts commit 1f87ef4.
…ppEmitter methods
josel-amd
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
The diff to upstream in this file is slowly but steadily starting to get meaningful. At some point we should think about pushing all upstream, but not now. If I recall correctly, this exact same trick - the fake emitter - is used somewhere in the MLIR ASM printer to print all the aliases before printing the actual IR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.