[FXML-5417] TileUsingInterface: drop unused extract_slice #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgehre-amd
approved these changes
Jan 3, 2025
|
Is there a way to test this? |
|
Yes, using the transform op that calls tiling and fusion. I figured the dead code was also there when using it, and would only go away after canonicalization. Now it goes away straight. |
cferry-AMD
commented
Jan 6, 2025
mlir/test/Dialect/Linalg/transform-op-fuse-into-containing.mlir
Outdated
Show resolved
Hide resolved
cferry-AMD
commented
Jan 6, 2025
josel-amd
approved these changes
Jan 6, 2025
….tiling_extract_slice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiling an op causes
extract_sliceops to be inserted between the producer of its operands and the tiled operation, so the tiled operation works on a tile of the data.Up to this PR, these
extract_slices are left unused when tiling the producer itself. Even though DCE will eventually eliminate those unused ops, the producer op is not trivially dead at the end of tiling and until DCE runs. Therefore, the producer may still be matched by other patterns despite it being dead. In this case, this PR makes the producer trivially dead.