Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What ranges are the lighting parameters ks and kd distributed in? #20

Open
yzliu567 opened this issue Jun 2, 2021 · 2 comments
Open

Comments

@yzliu567
Copy link

yzliu567 commented Jun 2, 2021

Hi, did you print out and see how your predicted ks and kd are distributed on faces? I want to apply random lighting on albedo maps, so I need to randomly sample ks and kd. But I don't know how to set the range of them to sample.
Thank you.

@XingangPan
Copy link
Owner

@yzliu567 Hi, you need to revise the rand_light: [-0.9,0.9,-0.3,0.8,-0.1,0.7,-0.4] parameter in the config file.
The corresponding light sampling code is at gan2shape/model.py Line 752-762. This is also described in the Appendix of our paper.

@yzliu567
Copy link
Author

yzliu567 commented Jun 4, 2021

@yzliu567 Hi, you need to revise the rand_light: [-0.9,0.9,-0.3,0.8,-0.1,0.7,-0.4] parameter in the config file.
The corresponding light sampling code is at gan2shape/model.py Line 752-762. This is also described in the Appendix of our paper.

@XingangPan Hi, I mean, can I get a proper "final" ks and kd sampler without lighting prediction network? You've added the predicted light parameters to the sampled parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants