Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When resizing the client the desktop size is incorrect #205

Open
jkells opened this issue Aug 16, 2022 · 2 comments
Open

When resizing the client the desktop size is incorrect #205

jkells opened this issue Aug 16, 2022 · 2 comments
Labels
bug Something isn't working geometry

Comments

@jkells
Copy link

jkells commented Aug 16, 2022

Describe the bug
When resizing the client the desktop is automatically resized but the windows are placed in the wrong position and the mouse clicks no longer click the correct area.

It's like everything is offset, some things are off the screen and other areas of the desktop can't be accessed. See screenshot:

image

To Reproduce
Steps to reproduce the behavior:

  1. server command:
xpra start-desktop :8090 \
    -d auth \
    --no-daemon \
    --bind-tcp=0.0.0.0:8090,auth=env \
    --start="xfce4-session" \
    --resize-display=true \
  1. client command: Using HTML5 browser client
  2. specific action to trigger the bug: Just resize the window

System Information (please complete the following information):

  • Server OS: [Debian Bullseye - Running inside Docker on OSX]
  • Client OS: [ARM M1 MacOS 12.5 Using HTML5 client]
  • Xpra Server Version [xpra v4.3.2-r0 ARM package]
  • Xpra Client Version [Built in HTML5 Client]

Additional context
XPRA was installed in the Docker container using the instructions from: https://github.com/Xpra-org/xpra/wiki/Download#-for-debian-based-distributions

  • Reconnecting the client fixes the issue
  • Resizing the windows again by a few pixels can also fix the issue.
  • The issue doesn't exist when using the XPRA native client for MacOSX
  • The issue doesn't exist when using version: xpra v3.0.13-r28292 installed from the distro package source
  • I can reproduce the issue from the latest HTML5 client available here: https://xpra.org/html5/index.html
@jkells jkells added the bug Something isn't working label Aug 16, 2022
@azzoe
Copy link

azzoe commented Sep 6, 2022

I am also having this issue with Ubuntu 20.04 x86, using both xfce4-session and gnome-session (gdm3). Weirdly xrandr appears to be doing it's job and adding displays per browser resize, just the canvas html side is getting out of sync? I get weird top and left margins when checking in chrome dev tools. Bug also happens in firefox so not chrome related

@azzoe
Copy link

azzoe commented Sep 8, 2022

Here is my hacky fix for this, I've at least identified the issue is css related. The left (and top) margin is the culprit for the main desktop window. By making these !important overrides the incorrect values that the javascript is inserting.
image

@totaam totaam transferred this issue from Xpra-org/xpra Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working geometry
Projects
None yet
Development

No branches or pull requests

3 participants