Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies required for visualize functionality not included in setup.py #32

Open
timesler opened this issue Nov 12, 2020 · 1 comment

Comments

@timesler
Copy link
Contributor

There are dependencies required to run the visualize script that are not included as package dependencies in the setup.py

@timesler
Copy link
Contributor Author

timesler commented Nov 12, 2020

We potentially don't want to increase the package's dependency footprint massively, so if many more packages are required, we could handle it in a similar way to pandas, where it gives an informative message like this for dependencies that aren't required for the package's core operation:

>>> import pandas as pd
>>> pd.read_parquet('asdfad')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.9/site-packages/pandas/io/parquet.py", line 316, in read_parquet
    impl = get_engine(engine)
  File "/usr/local/lib/python3.9/site-packages/pandas/io/parquet.py", line 31, in get_engine
    raise ImportError(
ImportError: Unable to find a usable engine; tried using: 'pyarrow', 'fastparquet'.
A suitable version of pyarrow or fastparquet is required for parquet support.
Trying to import the above resulted in these errors:
 - Missing optional dependency 'pyarrow'. pyarrow is required for parquet support. Use pip or conda to install pyarrow.
 - Missing optional dependency 'fastparquet'. fastparquet is required for parquet support. Use pip or conda to install fastparquet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant