-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bxt_cap_start video name requires .mp4 or .wav suffix #57
Comments
Instead of having the file name dictate whether to record audio and video, I think having a cvar doing that seems better. This could play well with #56 problem of |
It is intentional because if you put a wrong extension it can result in weird ffmpeg errors or broken output. I don't think it's a good idea to let people use extensions which aren't explicitly supported. |
What do you think of having no extension specified in |
The current system where you set .mp4 for video and .wav for audio seemed pretty natural to me. Idk though, maybe I'm mistaken? Windows hides extensions by default, is that something people capturing videos use? |
Hmmm, it just has something related to #56 where one command of
Maybe I am not good with words to describe it right now but I could scrap together a pr for mentioned issue then maybe it can show. |
I am not yet 100% convinced this is a good way to invoke it. Still need to think more about it. |
For now I just think it is the better way to play well with already existing |
I think with the other suggestion this can be closed. |
I am wondering if we can make this not intentional. Since the video is sure to be mp4 or wav format, maybe it is possible to just add that implicitly? In the case of just record the audio, maybe we can have a cvar for that?
The text was updated successfully, but these errors were encountered: