plugin refactor for v4 #101
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FalcoSuessgott
force-pushed
the
refactor
branch
8 times, most recently
from
080a90b
to
1112d7e
Compare
|
looking for volunteers to test if anyone has some time ... |
FalcoSuessgott
force-pushed
the
refactor
branch
11 times, most recently
from
89c6c32
to
b6b999a
Compare
FalcoSuessgott
force-pushed
the
refactor
branch
3 times, most recently
from
5893fee
to
ad34599
Compare
FalcoSuessgott
force-pushed
the
refactor
branch
3 times, most recently
from
98f2e91
to
cef88b1
Compare
FalcoSuessgott
force-pushed
the
refactor
branch
9 times, most recently
from
83feed7
to
46e7c22
Compare
|
Wow. Massive change. |
Somehwat yeah, the logic stays the sams (curl/wget download and goss validate invokation). Also added a lot of testing (acceptance and e2e. See github action test) |
|
Is there anything I can do in order to get a review. I understand it's a big change, but I'm confident that the tests ensure functionality. I would like to get some feedback about running this plugin on Windows tho. I'm also open to change parts of the input attributes, mentioned above. |
|
Sorry for the delay in looking at this (been super busy for the last few weeks). I built the plugin, installed it manually and created a test packer file using docker as the source. My packer file is super simple, so I have not tested every single option/knob, but I think the change is pretty solid from looking at the code: packer {
required_plugins {
docker = {
version = ">= 1.0.10"
source = "github.com/hashicorp/docker"
}
goss = {
version = "0.0.1"
source = "github.com/YaleUniversity/goss"
}
}
}
source "docker" "ubuntu" {
image = "ubuntu:jammy"
commit = true
}
build {
name = "learn-packer"
sources = [
"source.docker.ubuntu"
]
provisioner "shell" {
environment_vars = [
"FOO=hello world",
]
inline = [
"echo $PWD",
"apt update",
"apt install -y curl",
"echo Adding file to Docker Container",
"echo \"FOO is $FOO\" > example.txt",
]
}
provisioner "goss" {}
}goss.yaml: file:
example.txt:
exists: trueResult: |
F21
approved these changes
Aug 1, 2024
|
Any reviewers who can review and approve this? |
|
I'll take a look through the code @FalcoSuessgott @F21. It may take me a few days to get to it all as I am fairly busy on projects here at the University. |
|
Just to note: Added wiz vulnerability scanning tool to the university org, waiting on that to do its security scanning assessment before I approve. The scanning report should show up here on the PR. |
|
Thanks so much for your time and effort. |
FalcoSuessgott
force-pushed
the
refactor
branch
from
46e7c22
to
101813b
Compare
Wiz Scan Summary
|
![wiz-inc-91ace9494b[bot]](https://avatars.githubusercontent.com/u/5084400?s=60&v=4){kind=small}
FalcoSuessgott
force-pushed
the
refactor
branch
from
101813b
to
5b80eac
Compare
FalcoSuessgott
force-pushed
the
refactor
branch
from
5b80eac
to
e19754e
Compare
|
Alrighty, squashed the commits and removed the plugin docs stuff for now, as I want to have these in a separate PR. wiz found 1 vuln., which I fixed. Looking good from my side :) |
|
found a bug when working with paths: amazon-ebs.ubuntu: Detecting wether "tmp/goss.yaml" includes other gossfiles ...
amazon-ebs.ubuntu: Found [node_exporter_tests.yml] referenced in "tmp/goss.yaml"
amazon-ebs.ubuntu: Uploading [tmp/goss.yaml node_exporter_tests.yml] to target system ....
amazon-ebs.ubuntu: Uploading "tmp/goss.yaml" to "/tmp/tmp/goss.yaml"
amazon-ebs.ubuntu: Uploading "node_exporter_tests.yml" to "/tmp/node_exporter_tests.yml"
amazon-ebs.ubuntu: Running goss validate ...
amazon-ebs.ubuntu: Error: no matched files were found: "/tmp/tmp/node_exporter_tests.yml"gonna fix it and set it again for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4)