Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only Dots were shown in when drawing signature on Android #333

Open
huziidroid opened this issue Oct 5, 2023 · 2 comments
Open

Only Dots were shown in when drawing signature on Android #333

huziidroid opened this issue Oct 5, 2023 · 2 comments

Comments

@huziidroid
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-native-signature-canvas@4.7.1 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-signature-canvas/index.js b/node_modules/react-native-signature-canvas/index.js
index b30c561..195f1c0 100644
--- a/node_modules/react-native-signature-canvas/index.js
+++ b/node_modules/react-native-signature-canvas/index.js
@@ -263,6 +263,7 @@ const SignatureView = forwardRef(
     return (
       <View style={[styles.webBg, style]}>
         <WebView
+          nestedScrollEnabled={true}
           bounces={false}
           style={[webviewContainerStyle]}
           scrollEnabled={scrollable}

This issue body was partially generated by patch-package.

@nicholascm
Copy link

Ran into this exact issue last week - brilliantly simple fix - thanks @huziidroid

@ebarahona
Copy link

ebarahona commented Aug 14, 2024

Ran into this issue as well, after lot's of hours messing with gesture handlers and scrollviews, I also ran into the same solution however I found that the library has a property so you can pass the property rather than patching the package.

`
import SignatureView, { SignatureViewRef } from 'react-native-signature-canvas';

...

<SignatureView
nestedScrollEnabled={true} // pass the prop
...

`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants