Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New general page: FTC tab gives React warning #21728

Closed
11 tasks
igorschoester opened this issue Oct 21, 2024 · 0 comments · Fixed by #21756
Closed
11 tasks

New general page: FTC tab gives React warning #21728

igorschoester opened this issue Oct 21, 2024 · 0 comments · Fixed by #21756
Assignees

Comments

@igorschoester
Copy link
Member

  • I've read and understood the contribution guidelines.
  • I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened

To Reproduce

Step-by-step reproduction instructions

  1. Enable debug output (SCRIPT_DEBUG)
  2. Visit Yoast > General
  3. Notice the warning in the browser console:

Warning: Failed prop type: The prop onDiscard is marked as required in UnsavedChangesModal, but its value is undefined.

The useBlocker can return undefined for proceed (and reset) for specific states.
See their type def in the documentation: https://reactrouter.com/en/main/hooks/use-blocker

Expected results

  1. No prop warnings

Actual results

  1. Prop warning

Screenshots, screen recording, code snippet

If possible, please provide a screenshot, a screen recording or a code snippet which demonstrates the bug.

Technical info

  • If relevant, which editor is affected (or editors):
  • Block Editor
  • Gutenberg Editor
  • Elementor Editor
  • Classic Editor
  • Other:
  • Which browser is affected (or browsers):
  • Chrome
  • Firefox
  • Safari
  • Other:

Used versions

  • Device you are using:
  • Operating system:
  • PHP version:
  • WordPress version:
  • WordPress Theme:
  • Yoast SEO version:
  • Gutenberg plugin version:
  • Elementor plugin version:
  • Classic Editor plugin version:
  • Relevant plugins in case of a bug:
@Yoast Yoast deleted a comment Oct 25, 2024
@igorschoester igorschoester self-assigned this Oct 28, 2024
@igorschoester igorschoester removed their assignment Oct 28, 2024
@pls78 pls78 assigned pls78 and unassigned pls78 Oct 29, 2024
@leonidasmi leonidasmi self-assigned this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants