-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How-to and FAQ blocks improvements #11926
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: there are still warnings related to the
Haven't fixed them because |
CR 👍 |
…github.com/Yoast/wordpress-seo into 10834-10766-how-to-faq-blocks-improvements
Acceptance 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Currently, focus management for keyboard users in these blocks is broken because it relied on the Gutenberg
unstableOnSetup
prop, which is now removed. To fully address focus management, we need a few fixes upstream first:A way to manage focus on the RichText component
WordPress/gutenberg#9740
Not assume the first focusable element in a block is an input of type text, a textarea, or a contenteditable:
WordPress/gutenberg#12648
Minor, but still relevant: refs don't work on the IconButton component:
WordPress/gutenberg#12615
Right now there’s no built-in way to get a reference to the TinyMCE editable area instance (and probably there shouldn't be, but still there should be a way to manage focus). Also, the How-To and FAQ blocks will see some refactoring soon so this PR only fixes what is easily fixable now.
Button
component instead of anIconButton
because the latter doesn't support refsonFocus
callbacks from the days, hours, minutes fields: not sure why they were used in the first placespeak()
messages when adding a new step or questionTest instructions
Fixed warnings:
on a newly created How-To block:
on a newly created How-To block when clicking the "Unordered list" toggle in the sidebar:
Fixes #10766
Fixes #10834
Fixes #11413