Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for arch other than x86_64 ? #42

Open
marillat opened this issue Jan 19, 2023 · 7 comments
Open

Support for arch other than x86_64 ? #42

marillat opened this issue Jan 19, 2023 · 7 comments

Comments

@marillat
Copy link
Contributor

Hi,
Would be nice if you can make VapourSynth-Editor working for others arches like ARM, POWERPC or X86
Thanks
Christian

@YomikoR
Copy link
Owner

YomikoR commented Jan 19, 2023

vspreview-rs may be a better starting point for your need. Anyway, patches are always appreciated.

@marillat
Copy link
Contributor Author

Thanks but the goal is to have a working vsedit
I'll try to hack .pro files and send a PR when ready.

@marillat
Copy link
Contributor Author

I added patches (3) sorry I don't know how to do only one patch...

I see only one issue this doesn't work when crosscompiling.

@YomikoR
Copy link
Owner

YomikoR commented Jan 20, 2023

Thanks for the PRs. May I merge (some of) them now or should I wait until the binaries are tested with these archs? The major concern might be the behavior of Qt GUI.

how to do only one patch

You may append further commits in your branch. I'm okay with the status quo though.

@marillat
Copy link
Contributor Author

I've updated all patches. I forgot to exclude src/libp2p/simd/p2p_sse41.cpp if the build isn't ARCHITECTURE_64_BIT
I'm waiting a feedback for the arm64 architecture.
I'll tell you if people find bug.

@YomikoR
Copy link
Owner

YomikoR commented Aug 10, 2023

Did you find any glitches when previewing clips with non mod-4 resolution?

@marillat
Copy link
Contributor Author

No. Seems to be working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants