Merge pull request #41 from Yoonit-Labs/development

Remove listener removal from destroy method
Yoonit-Labs · Jan 25, 2021 · 594f8ef · 594f8ef
2 parents f5ce87f + eec22c7
commit 594f8ef
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 3 deletions.
diff --git a/README.md b/README.md
@@ -116,7 +116,7 @@ fun buildCameraEventListener(): CameraEventListener = object : CameraEventListen
 | startPreview                 | -                                | -                                                                               | void        | Start camera preview if has permission.
 | startCaptureType             | `captureType: String`            | <ul><li>`"none"`</li><li>`"face"`</li><li>`"qcode"`</li><li>`"frame"`</li></ul> | void        | Set capture type none, face, QR Code or frame.
 | stopCapture                  | -                                | -                                                                               | void        | Stop any type of capture.
-| destroy                      | -                                | -                                                                               | void        | Remove camera preview and listeners.
+| destroy                      | -                                | -                                                                               | void        | Remove camera preview.
 | toggleCameraLens             | -                                | -                                                                               | void        | Set camera lens facing front or back.
 | setCameraLens                | `cameraLens: String`             | <ul><li>`"front"`</li><li>`"back"`</li></ul>                                    | void        | Set camera to use "front" or "back" lens. Default value is "front".
 | getCameraLens                | -                                | -                                                                               | Int         | Return `Int` that represents lens face state: 0 for front 1 for back camera.

diff --git a/app/src/main/java/ai/cyberlabs/yoonit/camerademo/MainActivity.kt b/app/src/main/java/ai/cyberlabs/yoonit/camerademo/MainActivity.kt
@@ -165,7 +165,6 @@ class MainActivity : AppCompatActivity() {
     fun cameraStateSwitchClick(view: View) {
         if (view is SwitchCompat) {
             if (view.isChecked) {
-                this.cameraView.setCameraEventListener(this.buildCameraEventListener())
                 this.cameraView.startPreview()
                 return
             }

diff --git a/yoonit-camera/src/main/java/ai/cyberlabs/yoonit/camera/CameraView.kt b/yoonit-camera/src/main/java/ai/cyberlabs/yoonit/camera/CameraView.kt
@@ -110,7 +110,6 @@ open class CameraView @JvmOverloads constructor(
      * Destroy camera.
      */
     fun destroy() {
-        this.setCameraEventListener(null)
         this.cameraController.destroy()
     }