Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional flag to convert const to single value enums #570

Closed
gassiss opened this issue Aug 29, 2023 · 2 comments · Fixed by #571
Closed

Add optional flag to convert const to single value enums #570

gassiss opened this issue Aug 29, 2023 · 2 comments · Fixed by #571

Comments

@gassiss
Copy link
Contributor

gassiss commented Aug 29, 2023

Hello! 👋

We rely on this library to generate JSON schemas to use with OpenAPI. Unfortunately, this PR introduced some breaking changes for us, as OpenAPI straight up doesn't allow constant values, and the workaround was to do exactly what the PR fixed.

Any chance we can get that behaviour back behind a feature flag? Seems like a pretty simple change, I have it working locally for our use case and would be happy to open a PR if that's OK.

Thanks for your work on this!

@domoritz
Copy link
Collaborator

Happy to accept a pull request. Maybe we can add a flag for openapi. If I recall correctly, there were some other requests that you can search for.

@gassiss
Copy link
Contributor Author

gassiss commented Aug 30, 2023

nice! I'll open a PR for review soon. Thanks for the quick feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants