Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

may firmwares which link with unexpected version of QMK be uploaded to Remap #126

Closed
koron opened this issue Jun 6, 2022 · 1 comment
Closed

may firmwares which link with unexpected version of QMK be uploaded to Remap #126

koron opened this issue Jun 6, 2022 · 1 comment
Labels
invalid This doesn't seem right

Comments

@koron
Copy link
Collaborator

koron commented Jun 6, 2022

Keycodes which described in the document may wrong.

It come from difference of QMK version, which fimwares linked with.

Keyball expected QMK/0.16.3.

But latest QMK is 0.17.0.

And SAFE_RANGE is changed at this commit qmk/qmk_firmware@68c04ee
It changes values of Keyball defined keycodes.
@zhyu zhyu mentioned this issue Nov 23, 2022
Closed
@koron koron added the invalid This doesn't seem right label Jan 22, 2023
@koron
Copy link
Collaborator Author

koron commented Jan 22, 2023

there are no problems on current uploaded firmwares.

so i close this.

@koron koron closed this as completed Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@koron