Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of queued tasks in server pool could overflow #1866

Closed
spolitov opened this issue Jul 22, 2019 · 0 comments
Closed

Number of queued tasks in server pool could overflow #1866

spolitov opened this issue Jul 22, 2019 · 0 comments
Assignees
Labels
area/docdb YugabyteDB core features

Comments

@spolitov
Copy link
Contributor

No description provided.

@spolitov spolitov self-assigned this Jul 22, 2019
@spolitov spolitov added the area/docdb YugabyteDB core features label Jul 22, 2019
spolitov added a commit that referenced this issue Jul 23, 2019
Summary:
When timeout happens for a local call, the service pool would (before this fix) decrease the number of queued tasks.
But the local call was never queued, so number of queued tasks could underflow and become negative.

Fixed by checking that call was queued before decreasing the number of queued tasks.

Test Plan: ybd debug --cxx-test cassandra_cpp_driver-test --gtest_filter CppCassandraDriverTest.LocalCallBackpressure

Reviewers: timur, mikhail, amitanand

Reviewed By: mikhail, amitanand

Subscribers: bogdan, amitanand, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D6933
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features
Projects
None yet
Development

No branches or pull requests

1 participant