Corrupted Samples

[OmegaFoxie]

Long story short the Wave 63 Sample (used in the plantation theme, for example) seems to be corrupted or something and sounds earbreaking. Living Waterway also uses that sample.
I'm not sure if other samples are corrupted as well, but this one was the most obvious one.

[Yukitty]

To be fair, that song sounded ear-breaking to begin with to me. I can't tell the difference. Do you mean that ever-so-slight buzzing it does? Hmm... I wonder if the sample is simply reading one byte too far or sommat.

[Yukitty]

Fixed in v1.09
Thanks for going so far to point this out when I wasn't paying attention! 👍

[Yukitty]

Something weird is going on here. I've fixed everything I could see and it still does this:

The start of the image (on the left) is actually the start of the sample. So having a weird corruption in the middle like that is... unusual.

[OmegaFoxie]

Sorry I wasn't keeping up with my notifications recently
That is REALLY weird.
Sadly I have no idea what could be going wrong there

[OmniKahedron]

I know this issue is OLD, but I have found Wave-63 isn't the only melody sample to have this strange distorsion, Wave-70 (Access) has the same thing

With summer break on the horizon I'll most likely look through the source code (having already partially skimmed through it a few times today), and try to rewrite it
(Even though C / C++ is an absolute pain for me lmao)

If you like I will gladly keep you updated if I make any discoveries and such.

(EDIT on Access: There's also these spikes at the start of the melody notes, but only in the right audio channel. I'm getting more and more convinced that some of the math is off or something)

(EDIT EDIT: When only playing the waves, the irregular "spikes" are always EXACTLY zero, which again, further suggests something being wrong with the code, and not the samples themselves)

[Yukitty]

Thanks for working on it. This was my first time looping and mixing samples at arbitrary speeds entirely in my own code, so...

[OmniKahedron]

I'll see what I (and possibly a few others) can do
But first I got a vacation coming up :3

[moonPtr]

Same guy that opened this issue, different name

Melody Wave 63...

Turns out, that's part of the ACTUAL sample, BUT when orgmaker resamples it for higher pitches, that little spike is "lost", making the wave smoother
If you play it in orgmaker at pitches below octave 2, it's clearly there
Since your plugin resamples / interpolates differently / less than orgmaker, the little "spike" occurs (inconsistently) at higher pitches too.

As for this:

I'm looking into it right now, but aside from that there doesn't seem to be anything terribly wrong with your code.

[moonPtr]

(top orgmaker, bottom in_org)

Turns out the´spikes in the right channel are caused by percussion instruments, and this happens with every percussion instrument.

also worth mentioning is the clear desync between recordings (see first pic), despite me aligning the starts sample perfect.

[Yukitty]

Okay. So the small spikes in the instruments are just because the instruments themselves were bad and my code doesn't lose as much information resampling them as the original. (Much like how the org headers have the wrong instruments set entirely for some tracks...) Well that's a depressing relief.

I have no idea when the right ear track started dropping the first sample of percussion like that, but it shouldn't be difficult to fix. (did it happen when I started trying to fix the non-percussion samples somehow? Or have I just not been paying attention to the percussion as much since they were distracting me?)...

The timing, though, that's something I was kind of aware of but didn't fix because it would take effort to make it "sound right" again. @_@; My ears are throwing me off when I try.