Custom configuration gets reset

[SangeloDev]

Description
When editing the forgejo configuration, I expect it to stay the same, though it resets on updates. Is there any reason this is the case?

Expected Behavior
Custom configuration doesn't change

Actual Behavior
Custom configuration gets replaced with stock configuration

[grosmanal]

Hello @SangeloDev, thank you for this issue.

Yunohost aims to provide to admins one click installable applications (https://yunohost.org/en/administer/admin_guide/apps). The drawback is that app packagers (me) choose the config that should fit to everybody.

The upgrade process need to overwrite the config file, in order to deploy new instructions needed by forgejo or to correct packaging mistakes (i.e. #27).
Unfortunately forgejo doesn't manage some kind of app.override.ini file you could change without being overwritten.

As a existing workaround, you should have notice, that the upgrade process warns you if there are changes in the app.ini. You can rely on it to put your config back.

The best I can do as app maintainer is to add some config fields the admin (you) could fill before installation (or in app config). These values should then be used to fill the app.ini file.

Can you describe your use case in order to evaluate if it could fit to other forgejo app users ? I don't want to develop something just for one user.
In other words, what are the config items you modify, and why ?

[SangeloDev]

For me it's branding, as I try to host a public service. When the config gets overwritten, my modifications to the branding get lost, like custom css, the site name, among others.
I've also added upon the default config with other options like meta colors, because the default green doesn't fit with my color scheme.
I can see other users also change their branding, so your suggestion wouldn't benefit just me, it would possibly help others as well. I completely understand though if you're not interested in adding it. In that case, I've already created a backup config that I'll manually replace then.
Thanks for your answer :D