Skip to content

Latest commit

 

History

History
103 lines (67 loc) · 2.93 KB

CONTRIBUTING.rst

File metadata and controls

103 lines (67 loc) · 2.93 KB
Raw

Contributing

Contributions are welcome, and they are greatly appreciated! Every little bit helps, and credit will always be given.

You can contribute in many ways:

Types of Contributions

Report Bugs

Report bugs at https://github.com/pcdshub/pcdsdaq/issues.

If you are reporting a bug, please include:

  • Any details about your local setup that might be helpful in troubleshooting.
  • Detailed steps to reproduce the bug.

Fix Bugs

Look through the GitHub issues for bugs. Anything tagged with "bug" is open to whoever wants to implement it.

Implement Features

Look through the GitHub issues for features. Anything tagged with "feature" is open to whoever wants to implement it.

Write Documentation

pcdsdaq could always use more documentation, whether as part of the official pcdsdaq docs, in docstrings, or even on the web in blog posts, articles, and such.

Submit Feedback

The best way to send feedback is to file an issue at https://github.com/pcdshub/pcdsdaq/issues.

If you are proposing a feature:

  • Explain in detail how it would work.
  • Keep the scope as narrow as possible, to make it easier to implement.
  • Remember that this is a volunteer-driven project, and that contributions are welcome :)

Get Started!

Ready to contribute? Here's how to set up pcdsdaq for local development.

  1. Fork the pcdsdaq repo on GitHub.

  2. Clone your fork locally:

    $ git clone git@github.com:your_name_here/pcdsdaq.git

  3. Install your local copy into a new conda environment. Assuming you have conda installed, this is how you set up your fork for local development:

    $ conda create -n pcdsdaq python=3.9 pip
$ cd pcdsdaq/
$ pip install -e .

  4. Create a branch for local development:

    $ git checkout -b name-of-your-bugfix-or-feature

    Now you can make your changes locally.

  5. Install and enable pre-commit for this repository:

    $ pip install pre-commit
$ pre-commit install

  6. Add new tests for any additional functionality or bugs you may have discovered. And, of course, be sure that all previous tests still pass by running:

    $ pytest -v

  7. Commit your changes and push your branch to GitHub:

    $ git add .
$ git commit -m "Your detailed description of your changes."
$ git push origin name-of-your-bugfix-or-feature

  8. Submit a pull request through the GitHub website.

Pull Request Guidelines

Before you submit a pull request, check that it meets these guidelines:

  1. The pull request should include tests.
  2. If the pull request adds functionality, the docs should be updated. Put your new functionality into a function with a docstring, and add the feature to the list in README.rst.
  3. The pull request should work for Python 3.9 and up. Check the GitHub Actions status and make sure that the tests pass for all supported Python versions.