Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No interface for required field CreditorReferenceID #436

Closed
robali opened this issue Aug 6, 2024 · 8 comments
Closed

No interface for required field CreditorReferenceID #436

robali opened this issue Aug 6, 2024 · 8 comments

Comments

@robali
Copy link

robali commented Aug 6, 2024

I want to create a debit (Lastschriftverfahren) as a payment method.
I do this by implementing and setting the interface IZUGFeRDTradeSettlementDebit. This allows me to set the IBAN and the Mandate. However, I didn’t find an interface to set the required field CreditorReferenceId (Gläubiger-ID). This should be an element directly below ApplicableHeaderTradeSettlement, but as far as I can tell, there are only interfaces for the attributes PaymentReference and InvoiceCurrentCode on this level, but not CreditorReferenceID.

Am I overseeing the interface?

@jstaerk
Copy link
Collaborator

jstaerk commented Aug 7, 2024

I'm not sure if it's already implemented, can you grep the source code?

@langfr
Copy link
Contributor

langfr commented Aug 7, 2024

CreditorReferenceID does not yet appear anywhere in the java code, only within different resource files (xsd, xslt, sch) for validation an visualization.
As this value is a direct child of HeaderTradeSettlementType it should be part of class Invoice, not part of IZUGFeRDTradeSettlementDebit.

  <xs:complexType name="HeaderTradeSettlementType">
    <xs:sequence>
      <xs:element name="CreditorReferenceID" type="udt:IDType" minOccurs="0"/>
      <xs:element name="PaymentReference" type="udt:TextType" minOccurs="0"/>
      <xs:element name="TaxCurrencyCode" type="qdt:CurrencyCodeType" minOccurs="0"/>
      <xs:element name="InvoiceCurrencyCode" type="qdt:CurrencyCodeType"/>
      ...

@sebastianschmitz1510
Copy link

I think this issue relates to an other open issue: #370

@robali
Copy link
Author

robali commented Aug 8, 2024

right Sebastian, issue #370 adresses the exact same problem.

@robali
Copy link
Author

robali commented Aug 8, 2024

I checked ... it's not implemented. Any chance it will be implemented in the next release :) ?

@langfr
Copy link
Contributor

langfr commented Aug 8, 2024

Created pull request #439 for this.

@robali
Copy link
Author

robali commented Aug 8, 2024

awesome, thanks so much !!!

@jstaerk
Copy link
Collaborator

jstaerk commented Aug 27, 2024

since I merged the PR i guess this is fixed in master head?

@jstaerk jstaerk closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants