Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please help a novice. No such file or directory #include "cstring" #140

Open
1 task done
Tracked by #111
VicAMMON opened this issue Sep 25, 2024 · 2 comments
Open
1 task done
Tracked by #111

Please help a novice. No such file or directory #include "cstring" #140

VicAMMON opened this issue Sep 25, 2024 · 2 comments
Assignees
Labels
🐞 Bug 🐞 OH DEAR!!! You seem to have spotted a bug! Pending 📌 This is waiting for me to check it out
Milestone

Comments

@VicAMMON
Copy link

Is there an existing issue for this bug?

  • I have searched the issues and there is no existing issue for this bug.

What development environment are you using?

Arduino IDE

What board are you using?

Arduino Nano 33 IoT

What part of CRSF for Arduino is this bug related to?

Build/Compile/Upload

Current behaviour

SerialBuffer.cpp:26:10: fatal error: cstring: No such file or directory
#include "cstring"

Expected behaviour

expected all works fine

Steps to reproduce

Just add library to Arduino IDE 2.3.2, and try to compile example.

Additional information

No response

@VicAMMON VicAMMON added Pending 📌 This is waiting for me to check it out 🐞 Bug 🐞 OH DEAR!!! You seem to have spotted a bug! labels Sep 25, 2024
@ZZ-Cat ZZ-Cat moved this to Todo in Development Schedule Oct 2, 2024
@ZZ-Cat ZZ-Cat added this to the Version 1.1.0 milestone Oct 2, 2024
@ZZ-Cat ZZ-Cat self-assigned this Oct 2, 2024
@nickdundee08
Copy link

I had the same problem and stumbled on a fix by replacing #include "cstring" with #include "string.h" in serialbuffer.cpp

@ZZ-Cat
Copy link
Owner

ZZ-Cat commented Oct 29, 2024

cstring is a C++ header, and string.h is a C header.
As a temporary workaround, you MAY use string.h in place of cstring. However, this is NOT RECOMMENDED because CRSF for Arduino is written in C++ (specifically C++23), not C.

I am not going to fix this straight away, as I have higher priorities with CRSF for Arduino.
For example: As my work with #138 progresses, this issue could resolve itself on its own while I clean up the code-base.

Currently, I have taken time off of all of my public facing projects and I will not be back until early 2025. In the meantime, I may check-in from time-to-time, and triage issues, but that's it for the time being.

For future reference: The Issues tab is reserved for bug reports and requests for new hardware support. For requests for help (among other things), use the Discussions tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug 🐞 OH DEAR!!! You seem to have spotted a bug! Pending 📌 This is waiting for me to check it out
Projects
Status: Todo
Development

No branches or pull requests

3 participants