Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duck Hunt #39

Merged
merged 8 commits into from
Jun 15, 2022
Merged

Duck Hunt #39

merged 8 commits into from
Jun 15, 2022

Conversation

CorinHyndman
Copy link
Contributor

No description provided.

@ZacharyPatten
Copy link
Collaborator

Thank you for your interest in contributing a #17 new game. This looks great! :)

Do you have an opinion on what you believe the "Weight" should be on the table in the root README.md?

We need to add some additional files (see the "New Game Contribution Checklist" on #17), but I can do that for you.

My main comment from a code review perspective is that I think we can optimize the code a bit. On large screen sizes the game seems to lag a bit. I have a few ideas on how we can easily optimize it. I will keep you updated if I make progress on this topic.

@ZacharyPatten ZacharyPatten changed the title Added Duck Hunt Duck Hunt Jun 12, 2022
@ZacharyPatten ZacharyPatten added the community contribution Games originally contributed by members of the community. Thank you! label Jun 12, 2022
@CorinHyndman
Copy link
Contributor Author

The "Weight" I would say is on par with Tanks so maybe a 4?

@ZacharyPatten
Copy link
Collaborator

ZacharyPatten commented Jun 14, 2022

I see you added some optimizations. Thanks! I will review when I have time. :)

Also, ignore the GitHub action breaking on your fork. I need to update my "Website Deploy" action to only run on my repo (and not on forks). Sorry!

@ZacharyPatten
Copy link
Collaborator

I have added the blazor port, and I made a few changes in hopes to prevent the game from crashing when the console window is resized.

I'm sure there is more improvement that could be done (especially in the blazor port), but everything seems functioning and pretty reliable. I feel like this pull request is ready to merge. :)

Thanks again for the great contribution!

Feel free to open up additional pull requests if you would like to update the game in the future.

@ZacharyPatten ZacharyPatten merged commit 3c38182 into dotnet:main Jun 15, 2022
Fuinny pushed a commit to Fuinny/dotnet-console-games that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community contribution Games originally contributed by members of the community. Thank you!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants