Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filepaths and go.mod contents to support default release tags #19

Open
ZachtimusPrime opened this issue Oct 13, 2020 · 1 comment

Comments

@ZachtimusPrime
Copy link
Owner

ZachtimusPrime commented Oct 13, 2020

  • move go.mod to root
  • move ./splunk/v2 to ./v2
  • update go.mod to reflect the change of path for the module so that specific release tags don't have to be created in the format splunk/vX.X.X
@ZachtimusPrime ZachtimusPrime changed the title Update go.mod path and contents to support default release tags Update filepaths and go.mod contents to support default release tags Oct 13, 2020
@antoineco
Copy link
Contributor

antoineco commented Oct 13, 2020

One note: after that change, it will be necessary to alias the package import for the package name to be a valid Go import (e.g. "splunk").

// before
import "github.com/ZachtimusPrime/Go-Splunk-HTTP/splunk/v2"

func f() {
    // implicitly available as "splunk"
    _ = &splunk.Client{}
}
// after
import splunk "github.com/ZachtimusPrime/Go-Splunk-HTTP/v2"

func f() {
    _ = &splunk.Client{}
}

I'm fine with that, but it's worth documenting it in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants