Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for StateService::any_ancestor_blocks #1302

Closed
3 of 5 tasks
Tracked by #745
teor2345 opened this issue Nov 16, 2020 · 2 comments
Closed
3 of 5 tasks
Tracked by #745

Tests for StateService::any_ancestor_blocks #1302

teor2345 opened this issue Nov 16, 2020 · 2 comments
Labels
A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup C-tracking-issue Category: This is a tracking issue for other tasks

Comments

@teor2345
Copy link
Contributor

teor2345 commented Nov 16, 2020 •
edited
Loading

Testing

  • Write unit tests and property tests for StateService::any_ancestor_blocks with a finalized state
  • Write unit tests and property tests for StateService::any_ancestor_blocks with a non-finalized and finalized state

Refactors

Add the block::Hash to QueuedBlock

  • Add a block::Hash to service::memory_state::QueuedBlock
  • Use that hash rather than re-calculating the hash in every function
  • Make StateService::check_contextual_validity take a QueuedBlock rather than a Block

Context

Tracks remaining work from PR #1271
@teor2345 teor2345 added A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup C-tracking-issue Category: This is a tracking issue for other tasks labels Nov 16, 2020
@teor2345 teor2345 added this to the First Alpha Release milestone Nov 16, 2020
@teor2345 teor2345 mentioned this issue Nov 16, 2020
Merged
2 tasks
@teor2345 teor2345 changed the title StateService::chain cleanup and tests StateService cleanup and tests Nov 16, 2020
@yaahc yaahc self-assigned this Nov 17, 2020
@teor2345
Copy link
Contributor Author

Some of these were done by @hdevalence recently, others aren't really a priority for the first alpha.

@teor2345 teor2345 added the S-needs-triage Status: A bug report needs triage label Dec 14, 2020
@teor2345 teor2345 mentioned this issue Jan 5, 2021
Closed
44 tasks
@teor2345 teor2345 changed the title StateService cleanup and tests StateService::chain cleanup and tests Jan 5, 2021
@teor2345 teor2345 changed the title StateService::chain cleanup and tests StateService::chain tests Jan 5, 2021
@teor2345 teor2345 changed the title StateService::chain tests Tests for StateService::any_ancestor_blocks Jan 5, 2021
@mpguerra mpguerra removed this from the v1.0.0-alpha.1 milestone Jan 11, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Feb 2, 2021
@mpguerra mpguerra mentioned this issue Jan 21, 2022
Closed
51 tasks
@teor2345
Copy link
Contributor Author

These tests still need to be done, but they aren't needed any time soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup C-tracking-issue Category: This is a tracking issue for other tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mpguerra @yaahc @teor2345