You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #1637 we fixed specific panics happening when the users tries to shutdown zebra with ctrl-c.
We should make a test for this:
add a small unit test that checks that IS_SHUTTING_DOWN is false:
at the start of the test, and
after you've spawned a shutdown() task using spawn_blocking
We don't need to check that IS_SHUTTING_DOWN becomes true - we'll notice the panics if that part of the code ever breaks.
Additionally we want to add tests where zebrad is killed and restarted after some time making sure the database is not corrupted in particular in the middle of checkpoints:
Add an acceptance test that makes sure we can restart in the middle of a checkpoint:
Add an acceptance test that waits for 10 (?) seconds, kills zebrad, and then restarts it (rather than using debug_stop_at_height)
Restarting in the middle of a checkpoint:
Add a height parameter to the restart_stop_at_height test
Run the test for heights 0, zebra_consensus::MAX_CHECKPOINT_HEIGHT_GAP / 2, and zebra_consensus::MAX_CHECKPOINT_HEIGHT_GAP
That way, we'll test that Zebra can restart:
after genesis
after an incomplete checkpoint
after a full checkpoint
after being killed (rather than exiting normally)
The text was updated successfully, but these errors were encountered:
In #1637 we fixed specific panics happening when the users tries to shutdown zebra with ctrl-c.
We should make a test for this:
at the start of the test, and
after you've spawned a shutdown() task using spawn_blocking
We don't need to check that IS_SHUTTING_DOWN becomes true - we'll notice the panics if that part of the code ever breaks.
Additionally we want to add tests where zebrad is killed and restarted after some time making sure the database is not corrupted in particular in the middle of checkpoints:
Add an acceptance test that makes sure we can restart in the middle of a checkpoint:
Restarting in the middle of a checkpoint:
Run the test for heights 0, zebra_consensus::MAX_CHECKPOINT_HEIGHT_GAP / 2, and zebra_consensus::MAX_CHECKPOINT_HEIGHT_GAP
That way, we'll test that Zebra can restart:
The text was updated successfully, but these errors were encountered: