Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement mempool transaction storage #2589

Closed
Tracked by #2309
mpguerra opened this issue Aug 9, 2021 · 0 comments · Fixed by #2651
Closed
Tracked by #2309

Implement mempool transaction storage #2589

mpguerra opened this issue Aug 9, 2021 · 0 comments · Fixed by #2651
Assignees
Labels
C-enhancement Category: This is an improvement

Comments

@mpguerra
Copy link
Contributor

mpguerra commented Aug 9, 2021

Motivation

We need to implement a mempool for transactions that have not yet been mined into a block

Specifications

This will be a very basic initial implementation of a mempool that can hold one transaction at a time

  • Create a stub mempool that is either just a hashmap or a struct wrapping a hash map, or one or two hash maps, to hold our tx’s, instead of logging them
    • must have methods to insert and remove transactions from the mempool
    • must handle WTX ids

Designs

https://jamboard.google.com/d/1HUhdqx8afJUqgiBdBcjCw0aAfDod9R9KBJeAH24U1Qg/viewer?f=0
We might want to create a new module to hold this in the zebrad crate

@mpguerra mpguerra added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Aug 9, 2021
@mpguerra mpguerra added this to the 2021 Sprint 16 milestone Aug 9, 2021
@mpguerra mpguerra mentioned this issue Aug 11, 2021
59 tasks
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Aug 16, 2021
@mpguerra mpguerra linked a pull request Aug 23, 2021 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: This is an improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants