Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated arrayvec dependency used by inferno #2980

Closed
teor2345 opened this issue Oct 31, 2021 · 3 comments · Fixed by #3013
Closed

Remove outdated arrayvec dependency used by inferno #2980

teor2345 opened this issue Oct 31, 2021 · 3 comments · Fixed by #3013
Labels
A-dependencies Area: Dependency file updates C-cleanup Category: This is a cleanup

Comments

@teor2345
Copy link
Contributor

teor2345 commented Oct 31, 2021

Motivation

Zebra currently depends on 3 different versions of the arrayvec crate.
Some of these versions are more than 2 years old.

If we remove outdated dependencies, Zebra will compile faster, its binaries will be smaller, and it will be more secure.

Tasks

  1. Check that the conflict still exists by removing the inferno exception from deny.toml, then running cargo deny check bans.

inferno Alternatives

Make flamegraph support an optional feature:

  1. Make inferno an optional dependency of zebrad, and use a feature to activate flamegraph support

Upgrade versions:

  1. Fork inferno and num-format, upgrade them to use the latest arrayvec, and make Zebra depend on our forked versions
  2. Submit PRs upstream
  3. Remove the exceptions for these crates in deny.toml.
@teor2345
Copy link
Contributor Author

teor2345 commented Nov 4, 2021

Closed by PRs #3011 and #3013.

@jvff jvff closed this as completed in #3013 Nov 4, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Nov 8, 2021
@teor2345
Copy link
Contributor Author

This wasn't actually resolved by these PRs.

@teor2345 teor2345 reopened this Nov 17, 2021
@teor2345
Copy link
Contributor Author

teor2345 commented Mar 1, 2022

We should do the simplest fix as part of a future version upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates C-cleanup Category: This is a cleanup
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants