Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade hyper to version 1.x.y in zebra-rpc and zebrad crate #7997

Closed
oxarbitrage opened this issue Nov 26, 2023 · 3 comments
Closed

Upgrade hyper to version 1.x.y in zebra-rpc and zebrad crate #7997

oxarbitrage opened this issue Nov 26, 2023 · 3 comments

Comments

@oxarbitrage
Copy link
Contributor

oxarbitrage commented Nov 26, 2023 •
edited by arya2
Loading

Motivation

The hyper team did a major release from 0.14.27 to 1.0.0 where significant changes were introduced, including some breaking changes, notably replacing the Body enum with a trait.

The proposed dependabot bumps here have building issues with hyper.

What we did by now is to separate the rest of the upgrades in #7996 so we can decide what to do here isolated from the rest of the bumps that had no issues.

Possible Solution

Upgrade guide: https://hyper.rs/guides/1/upgrading/

  • Wait for jsonrpc-http-server to upgrade
  • Replace jsonrpc crates with tonic and a Codec impl for JSON
@mpguerra mpguerra added this to Zebra Nov 26, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Zebra Nov 26, 2023
@oxarbitrage oxarbitrage changed the title Upgrade hyper in zebra-rpc crate Upgrade hyper in zebra-rpc and zebrad crate Nov 26, 2023
This was referenced Nov 27, 2023
Closed
Closed
@arya2 arya2 mentioned this issue Nov 27, 2023
Closed
@teor2345 teor2345 changed the title Upgrade hyper in zebra-rpc and zebrad crate Upgrade hyper to version 1.x.y in zebra-rpc and zebrad crate Nov 28, 2023
@mpguerra
Copy link
Contributor

Blocked on paritytech/jsonrpsee#1257

@mpguerra
Copy link
Contributor

Blocked on paritytech/jsonrpsee#1257

This is now complete, should we work on this one soon?

@mpguerra
Copy link
Contributor

This seems to have been done already

@github-project-automation github-project-automation bot moved this from New to Done in Zebra Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Zebra
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpguerra @oxarbitrage