Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT plugin issue #24

Open
oscar-broman opened this issue Sep 12, 2015 · 2 comments
Open

JIT plugin issue #24

oscar-broman opened this issue Sep 12, 2015 · 2 comments

Comments

@oscar-broman
Copy link
Collaborator

This cause the JIT plugin to crash, even if the code is not run:

#emit switch 0

I solved it by changing it into this:

case OP_SWITCH: {
    new x = 0;
    switch (x) { case 0: return ReadOpcodeNearThis(-36); }
}

However, it only works when compiling with O1 so obviously it's not a good solution.

@Zeex
Copy link
Owner

Zeex commented Sep 18, 2015

Does this even work with the JIT? I got crashes too, but they seemed random and the function returned garbage for the opcodes I tried. I'll see if that could be fixed.

@oscar-broman
Copy link
Collaborator Author

After the patch I did, it works. I think many things don't work in amx_assembly with the JIT, but I only modify the AMX in OnJITCompile, which works just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants