Skip to content
This repository has been archived by the owner on Sep 25, 2023. It is now read-only.

Scrolling to zoom the camera in tracking mode does not work in some cases. #300

Closed
Zemanzo opened this issue Sep 15, 2021 · 1 comment · Fixed by #302
Closed

Scrolling to zoom the camera in tracking mode does not work in some cases. #300

Zemanzo opened this issue Sep 15, 2021 · 1 comment · Fixed by #302
Labels
bug something isn't working client affects the client

Comments

@Zemanzo
Copy link
Owner

Zemanzo commented Sep 15, 2021

Expected behavior
When using the mousewheel in the viewport whilst the camera is in tracking mode, it should zoom in (or out) on the currently tracked marble.

Actual behavior
When using the mousewheel in the viewport whilst the camera is in tracking mode, it does not zoom. This is because the DeltaY value is way too big since it does not take the DeltaMode into account. Read more here: https://developer.mozilla.org/en-US/docs/Web/API/WheelEvent/deltaY

Reproduction steps

  1. Just scroll the damn thing I basically explained it above already.

Platform
OS: Windows 10
Browser version: Firefox Developer Edition (93.0b5 (64-bit))
Build version: 1.3.1 (latest /dev branch)

@Zemanzo Zemanzo added bug something isn't working client affects the client labels Sep 15, 2021
@Zemanzo
Copy link
Owner Author

Zemanzo commented Sep 16, 2021

Might be a duplicate of #267

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug something isn't working client affects the client
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant