Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace secp256k1 with libsecp256k1 pure rust implementation #135

Closed
wants to merge 5 commits into from

Conversation

Gauthamastro
Copy link

PR replaces secp256k1 with libsecp256k1 pure implementation from paritytech.

@elichai
Copy link
Contributor

elichai commented Sep 7, 2021

I'll link these 2 issues again: #44 and #43, and I recommend you read them before :)
I'll quote what I wrote in #32:

I would prefer https://github.com/RustCrypto/elliptic-curves/tree/master/k256 or something based on fiat-crypto.

but even then it's quite scary, as libsecp256k1 is very battle tested.
another option would be to fork libsecp256k1 and write bindings to the internal functionality, that allows infinity, jacobian points and more.

As for the SGX problems, I used libsecp256k1 in SGX in the past, and worked a lot to make rust-secp256k1 work in virtually every environment possible (See rust-bitcoin/rust-secp256k1#100, rust-bitcoin/rust-secp256k1#115, rust-bitcoin/rust-secp256k1#125, rust-bitcoin/rust-secp256k1#130)
So if you can show me what's not working for you I'd love to try and help (I can also do that privately in Telegram/IRC/Signal if you prefer)

@Gauthamastro
Copy link
Author

Closing this as per our discussion in telegram.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants