feat: [CO-788] add ability to parse extended filename from uploads #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- follow RFC-6266 for parsing extended filename from Content-disposition header while handling multipart uploads requests.
- unit tests to verify the expected parsing of filename from content-disposition header - cover both plain and multipart upload requests
keshavbhatt
requested review from
flanciotti,
frisonisland,
aheeva-yuliya and
a user
and removed request for
a team
frisonisland
approved these changes
Sep 27, 2023
store/src/test/java/com/zimbra/cs/service/util/ContentDispositionParserTest.java
Show resolved
Hide resolved
store/src/test/java/com/zimbra/cs/service/FileUploadServletTest.java
Outdated
Show resolved
Hide resolved
store/src/test/java/com/zimbra/cs/service/FileUploadServletTest.java
Outdated
Show resolved
Hide resolved
Comment on lines
+470
to
+471
| getClass().getResource("\u0421\u043e\u0431\u044b\u0442\u0438\u044f.txt")) | ||
| .toURI()); // События.txt |
There was a problem hiding this comment.
I think passing События works (it does for me at least)
There was a problem hiding this comment.
strange, It was not working for me.
ghost
approved these changes
Oct 5, 2023
aheeva-yuliya
approved these changes
Oct 12, 2023
matteobaglini
added a commit
that referenced
this pull request
Oct 18, 2023
* devel: (71 commits) fix: [CO-861] mailbox wsdl generator uses soap 12 soap protocol wrong content type (#356) chore: deprecate zimbraFeatureMailEnabled attribute (#352) feat: follow RFC-6266 to parse extended filename from uploads (#335) chore: 23.11.0 devel + minor build changes (#339) fix: CO-823 FreeBusy missing uid parameter in CalDav request (#343) test: [CO-822] add test for notification when schedule-agent=client (#350) feat: add ubuntu 22.04 (jammy jellyfish) support (#347) fix: log category does not exist (#346) chore: modify slogger configuration (#341) chore: bump 4.9.1 (#345) revert: "feat: zimlet code cleanup (#310)" (#344) feat: deprecate CSRF-related LDAP-attributes ref: CO-818 chore: remove -SNAPSHOT (#337) chore: 23.10.0 + 4.9.0 chore: bump 4.8.3 (#333) fix: delete CalDav appointment (#332) chore: IN-620: use syft and dependency-track platform for SBOM (#325) feat: add 127.0.0.1 to MailTrustedIP to prevent loss of OIP (#328) chore: wrong bump (#331) chore: bump rc 4.8.2 (#330) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed: