fix: CO-823 FreeBusy missing uid parameter in CalDav request #343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an open bug about the Free/Busy response missing the UID parameter.
From RFC https://www.rfc-editor.org/rfc/rfc5545 the FreeBusy component, VFREEBUSSY, is required to have the uid.
Providing a null uid will result in the UID to not be added as I don't know where to get the value in all other cases.
But for this use case (CalDAV request) and due to the current bug I have decided to answer back the same UID that was provided in the request.
Reason is while debugging with a client (Thunderbird), I saw the UID in the request was different every time, plus, quoting from the RFC:
and
About the tests: I have added a test about the response (behavioral)
and a couple of UT for the FreeBusy class. I didn't opt for a refactor or adding more tests, but this class is lacking a lot of them