feat: [ZIF-982] remove message size check on save draft #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- an empty attachment does not affect message size
- extract inner classes of ParseMimeMessage
frisonisland
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
zextrasGiovanniDefacci
force-pushed
the
ZIF-982
branch
from
f335787 to
27678fa
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
…me method to handleInlineAttachments - add tests on handling upload of inline attachments
This comment has been minimized.
This comment has been minimized.
frisonisland
requested review from
sonersivri,
danielemegna and
ppolito-zextras
and removed request for
a team
|
Analysis Details0 Issues
Coverage and Duplications
Project ID: zextras:zm-mailbox |
sonersivri
approved these changes
Apr 3, 2024
zextrasGiovanniDefacci
approved these changes
Apr 3, 2024
frisonisland
changed the title
AlessioCoser
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes check on email size when saving a draft (see first commit).
All other changes are about light-refactoring (method names, visibility, inlined values, private methods) of ParseMimeMessage in its own package and tests. Some private methods have been simplified as they were called only with arguments always having the same value, so value has been inlined.
Thanks to this refactor, test and analysis we identified 3 major usages for ParseMimeMessage: