feat: add systemd units #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M0Rf30
requested review from
mbarto,
AlessioCoser and
frisonisland
and removed request for
a team
Refs: IN-557
M0Rf30
force-pushed
the
IN-557-feat-systemd
branch
from
c763e70 to
6cc3e0a
Compare
sonersivri
approved these changes
Apr 9, 2024
|
Hi @M0Rf30 what about adding systemd units for mailbox and milter on https://github.com/zextras/carbonio-appserver/blob/main/appserver/PKGBUILD ? Currently appserver-service contains mailbox sidecar and I'm not sure about putting milter service in carbonio-common-appserver-conf |
keshavbhatt
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Aside from the placement of these files, as noted by @frisonisland, everything appears satisfactory. 🚀
|
Analysis Details0 Issues
Coverage and Duplications
Project ID: zextras:zm-mailbox |
frisonisland
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: IN-557