Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [CO-1249] Better handling of GalGroup type matches in FullAutoComplete API #532

Merged
merged 3 commits into from
Jun 28, 2024
Merged

fix: [CO-1249] Better handling of GalGroup type matches in FullAutoComplete API #532

merged 3 commits into from
Jun 28, 2024

Conversation

keshavbhatt
Copy link
Member

@keshavbhatt keshavbhatt commented Jun 26, 2024 •
edited
Loading

What's changed:

  • add a type-safe builder class AutoCompleteMatchElementBuilder to ensure null-safe handling when serializing AutoCompleteMatch back to the Element class. This prevents NullPointerExceptions (NPEs) in specific types of autocomplete matches, such as Distribution list (GalGroup Match type), which may have some fields uninitialized (null).
  • enhanced API resilience: FAC API now returns matches from "other preferred accounts" if the passed "preferred account" does not exist, instead of failing.

@keshavbhatt
fix: [CO-1249] better handling of GalGroup type matches
7deb6ae 
by adding null checks on returned AutoCompleteMatch objects + null check on requestedAccount before accessing it
@keshavbhatt keshavbhatt changed the title fix: [CO-1249] better handling of GalGroup type matches in FullAutoComplete API fix: [CO-1249] Better handling of GalGroup type matches in FullAutoComplete API Jun 26, 2024
@sonarqube-zextras Sonarqube Zextras
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 98.20% Coverage (27.70% Estimated after merge)
  • Duplications 0.00% Duplicated Code (2.90% Estimated after merge)

Project ID: zextras:zm-mailbox

View in SonarQube

@sonarqube-zextras Sonarqube Zextras
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 98.30% Coverage (27.70% Estimated after merge)
  • Duplications 0.00% Duplicated Code (2.90% Estimated after merge)

Project ID: zextras:zm-mailbox

View in SonarQube

@keshavbhatt keshavbhatt marked this pull request as ready for review June 27, 2024 06:32
@keshavbhatt keshavbhatt requested a review from a team as a code owner June 27, 2024 06:32
@sonarqube-zextras Sonarqube Zextras
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 95.70% Coverage (27.70% Estimated after merge)
  • Duplications 0.00% Duplicated Code (2.90% Estimated after merge)

Project ID: zextras:zm-mailbox

View in SonarQube

1 similar comment
@sonarqube-zextras Sonarqube Zextras
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 95.70% Coverage (27.70% Estimated after merge)
  • Duplications 0.00% Duplicated Code (2.90% Estimated after merge)

Project ID: zextras:zm-mailbox

View in SonarQube

@keshavbhatt keshavbhatt merged commit 818b57d into main Jun 28, 2024
3 checks passed
@keshavbhatt keshavbhatt deleted the CO-1249 branch June 28, 2024 09:45
matteobaglini added a commit that referenced this pull request Jul 1, 2024
@matteobaglini
Merge branch 'main' into CO-1244-qa-fix-get-account-info-and-get-info…
c2f9701 
…-return-500-error-code-when-guest-accounts-dont-exist-anymore

* main:
  chore: [ci] Remove SBOM generater stage (#535)
  fix: [CO-1249] Better handling of GalGroup type matches in FullAutoComplete API (#532)
  chore: systemd: add LimitNOFILE to some systemd units (#529)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonersivri sonersivri sonersivri approved these changes

@aheeva-yuliya aheeva-yuliya aheeva-yuliya approved these changes

@matteobaglini matteobaglini Awaiting requested review from matteobaglini matteobaglini is a code owner automatically assigned from zextras/kc

@frisonisland frisonisland Awaiting requested review from frisonisland frisonisland is a code owner automatically assigned from zextras/kc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keshavbhatt @sonersivri @aheeva-yuliya