fix: DeleteAccount fails mailbox startup during bootstrap causing installation to be stuck #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allation is stuck - during Carbonio installation, during bootstrap, instantiation of DeleteAccount fails, causing Mailbox to not start properly (Jetty: UNAVAILABLE) because consul token (and Consul) are not installed yet.
frisonisland
requested review from
sonersivri,
keshavbhatt,
drazen04,
federicorispo,
galvagnimatteo,
mbarto,
zextrasGiovanniDefacci,
FrancescoGottardi,
giuliano176 and
matteobaglini
and removed request for
a team
sonersivri
approved these changes
Oct 29, 2024
matteobaglini
approved these changes
Oct 29, 2024
keshavbhatt
approved these changes
Oct 29, 2024
frisonisland
changed the title
This comment has been minimized.
This comment has been minimized.
- add empty constructor
|
Analysis Details6 Issues
Coverage and Duplications
Project ID: zextras:zm-mailbox |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing Carbonio, during bootstrap, instantiation of DeleteAccount fails, causing Mailbox to not start properly (Jetty: UNAVAILABLE) because consul token (and Consul) are not installed/available yet.
Consul and Consul tokens are available only after bootstrap, so we made the SOAP layer (Admin, DeleteAccount API) to "loosely" depend on the message broker client (opted for a Try)