Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [CO-1720] delete account from mailbox only after files finished deleting blobs from powerstore #637

Merged
merged 27 commits into from
Dec 12, 2024
Merged

fix: [CO-1720] delete account from mailbox only after files finished deleting blobs from powerstore #637

merged 27 commits into from
Dec 12, 2024

Conversation

galvagnimatteo
Copy link
Contributor

  • Added a message broker consumer for a confirmation event emitted by files once blobs are deleted from powerstore
  • Updated service discover client to get if a service is installed on current infrastructure
  • Now the delete account operation, if files is installed, does not immediatly delete an account: the real deletion will happen after consumer receives the confirmation event

Refs: CO-1720

@galvagnimatteo galvagnimatteo requested a review from a team as a code owner December 9, 2024 16:02
@galvagnimatteo galvagnimatteo requested review from sonersivri, keshavbhatt and frisonisland and removed request for a team December 9, 2024 16:02
@sonarqube-zextras Sonarqube Zextras

This comment has been minimized.

Sign in to view
@frisonisland frisonisland changed the base branch from devel to main December 12, 2024 09:22
@keshavbhatt keshavbhatt changed the title fix: delete account from mailbox only after files finished deleting blobs from powerstore fix: [CO-1720] delete account from mailbox only after files finished deleting blobs from powerstore Dec 12, 2024
@galvagnimatteo galvagnimatteo force-pushed the CO-1720-delete-account-from-mailbox-only-after-files-finished-deleting-blobs-from-powerstore branch from ef81485 to 9008012 Compare December 12, 2024 15:07
@sonarqube-zextras Sonarqube Zextras
Copy link

Failed

  • 42.60% Coverage on New Code (is less than 80.00%)
  • 2 New Issues (is greater than 0)

Analysis Details

2 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 2 Code Smells

Coverage and Duplications

  • Coverage 42.60% Coverage (29.30% Estimated after merge)
  • Duplications 0.00% Duplicated Code (3.00% Estimated after merge)

Project ID: zextras:zm-mailbox

View in SonarQube

@galvagnimatteo galvagnimatteo merged commit a7e029b into main Dec 12, 2024
2 of 3 checks passed
@galvagnimatteo galvagnimatteo deleted the CO-1720-delete-account-from-mailbox-only-after-files-finished-deleting-blobs-from-powerstore branch December 12, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonersivri sonersivri sonersivri left review comments

@keshavbhatt keshavbhatt keshavbhatt approved these changes

@frisonisland frisonisland frisonisland approved these changes

@matteobaglini matteobaglini Awaiting requested review from matteobaglini

@federicorispo federicorispo Awaiting requested review from federicorispo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@galvagnimatteo @sonersivri @keshavbhatt @frisonisland