Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the plugin thread safe #10

Closed
iemejia opened this issue Sep 13, 2017 · 2 comments
Closed

Make the plugin thread safe #10

iemejia opened this issue Sep 13, 2017 · 2 comments
Assignees
Milestone

Comments

@iemejia
Copy link

iemejia commented Sep 13, 2017

When running the plugin on a build in parallel with maven mvn --threads 1C I got this warning

[WARNING] *****************************************************************
[WARNING] * Your build is requesting parallel execution, but project      *
[WARNING] * contains the following plugin(s) that have goals not marked   *
[WARNING] * as @threadSafe to support parallel building.                  *
[WARNING] * While this /may/ work fine, please look for plugin updates    *
[WARNING] * and/or request plugins be made thread-safe.                   *
[WARNING] * If reporting an issue, report it against the plugin in        *
[WARNING] * question, not against maven-core                              *
[WARNING] *****************************************************************
[WARNING] The following plugins are not marked @threadSafe in Apache Beam :: Parent:
io.github.zlika:reproducible-build-maven-plugin:0.3
``
Maybe it is a good idea to ensure that the plugin is threadsafe and add the annotation if it is the case.
@Zlika Zlika self-assigned this Sep 14, 2017
@Zlika Zlika added this to the 0.4 milestone Sep 14, 2017
@Zlika
Copy link
Owner

Zlika commented Sep 14, 2017

Thanks for the report.
I reviewed the code and nothing prevents the plugin from being used in a parallel build.
Fixed by 9a80e21.

@Zlika Zlika closed this as completed Sep 14, 2017
@Zlika
Copy link
Owner

Zlika commented Oct 27, 2017

reproducible-build-maven-plugin version 0.4 has been released on Maven Central. Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants