Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set vendor / product id with image file name #290

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Set vendor / product id with image file name #290

merged 2 commits into from
Sep 1, 2023

Conversation

phe78
Copy link
Contributor

@phe78 phe78 commented Aug 31, 2023

ZuluSCSI displays the first 16 characters of the image file name (with path and extension removed) instead of fixed DRIVEINFO as defined in ZuluSCSI_config.h

Copy link
Collaborator

@PetteriAimonen PetteriAimonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the memory leak and potential crash in get_image_name() must be fixed before merge.

I would prefer to see this use a separate setting ini-file setting that can be used for any device, instead of tying to EMU quirks, but either is acceptable to me.

src/ZuluSCSI_disk.cpp Outdated Show resolved Hide resolved
lib/SCSI2SD/include/scsi2sd.h Show resolved Hide resolved
src/ZuluSCSI_disk.cpp Outdated Show resolved Hide resolved
src/ZuluSCSI_disk.cpp Show resolved Hide resolved
@PetteriAimonen
Copy link
Collaborator

Thanks for contributing, I left a few comments in review.

If you run into any problems or just don't feel like doing changes, just let us know and we'll see how to proceed.

@phe78
Copy link
Contributor Author

phe78 commented Aug 31, 2023

thanks for your prompt feedback, all great comments, I'll come back asap with updated code

@PetteriAimonen
Copy link
Collaborator

Thanks, looks good to merge now.

@phe78
Copy link
Contributor Author

phe78 commented Sep 1, 2023

Thanks !

@aperezbios aperezbios merged commit 2dc430b into ZuluSCSI:main Sep 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants