Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Improve Functional Tests related to env core commands #981

Open
GuillaumeFalourd opened this issue Jun 30, 2021 · 0 comments · May be fixed by #1054
Open

Improve Functional Tests related to env core commands #981

GuillaumeFalourd opened this issue Jun 30, 2021 · 0 comments · May be fixed by #1054
Labels
good first issue Good for newcomers 🔨 improvement Improvement in features ✔️ refined ISSUE refined by the Ritchie Team :octocat: github-actions Related to github actions workflows
Milestone
Community

Comments

@GuillaumeFalourd
Copy link
Contributor

GuillaumeFalourd commented Jun 30, 2021 •
edited
Loading

What would you like to be added

Context

It is possible to perform functional test (cf our Developer Guide) using Github Actions, to test the behaviour of Ritchie CLI core commands.

To do so, the team created an action: test-cli-commands-action

At the beginning, this action only allowed to test command lines with SUCCESS returns. But now, it also allows to test command lines with ERROR returns.

As SUCCESS scenarios are already tested for env commands, an improvement would be to add ERROR scenarios following the same logic.

Related file: https://github.com/ZupIT/ritchie-cli/blob/master/.github/workflows/test-env-commands.yml

Why is this needed

  • To improve the tool quality and the development experience.
@GuillaumeFalourd GuillaumeFalourd added good first issue Good for newcomers 🔨 improvement Improvement in features ✔️ refined ISSUE refined by the Ritchie Team :octocat: github-actions Related to github actions workflows labels Jun 30, 2021
@fabianofernandeszup fabianofernandeszup added this to the Community milestone Jul 7, 2021
@dittrichlucas dittrichlucas linked a pull request Oct 28, 2021 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers 🔨 improvement Improvement in features ✔️ refined ISSUE refined by the Ritchie Team :octocat: github-actions Related to github actions workflows
Projects
None yet
Milestone
Community
Development

Successfully merging a pull request may close this issue.

Test/env error cases dittrichlucas/ritchie-cli
2 participants
@GuillaumeFalourd @fabianofernandeszup