Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VoxelStream.load_voxel_block() and .save_voxel_block() have a misleadingly named parameter #715

Closed
clarence112 opened this issue Nov 24, 2024 · 2 comments

Comments

@clarence112
Copy link

both VoxelStream.load_voxel_block() and VoxelStream.save_voxel_block() have a parameter named origin_in_voxels. Confusingly, it does not take the origin in voxel coordinates, but rather in block coordinates. Specifying (16, 16, 16) will return block (16, 16, 16), rather than the block containing position (16, 16, 16).

@Zylann
Copy link
Owner

Zylann commented Nov 24, 2024

Indeed, they take block coordinates. I changed that a while ago, but forgot to update parameter names. Will need to update that.

@Zylann
Copy link
Owner

Zylann commented Nov 24, 2024

Fixed in 9d99f03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants