Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foundry build cache is disabled with --build-info (it always rebuilds) #285

Closed
karmacoma-eth opened this issue May 7, 2024 · 2 comments · Fixed by #289
Closed

foundry build cache is disabled with --build-info (it always rebuilds) #285

karmacoma-eth opened this issue May 7, 2024 · 2 comments · Fixed by #289
Labels
bug Something isn't working

Comments

@karmacoma-eth
Copy link
Collaborator

Describe the bug

halmos always starts by running forge build --build-info --root . --extra-output storageLayout metadata

We normally rely on forge to decide if a rebuild is necessary or not, however since we added --build-info it now always rebuilds.

This behavior was changed in foundry-rs/foundry#7358

The reason we added --build-info is to bring back the AST in the generated artifacts: #255

@karmacoma-eth karmacoma-eth added the bug Something isn't working label May 7, 2024
@karmacoma-eth
Copy link
Collaborator Author

what we really want is to bring the AST back. AFAIK there are 2 ways to do this:

Maybe as a workaround we can use --ast. If we're going to do that:

  • either we check the forge version first, and then only add the --ast flag if it's in a supported foundry version
  • or it will fail and we require the users to foundryup

@karmacoma-eth
Copy link
Collaborator Author

Related issue: foundry-rs/foundry#7379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant