Feat/batched opening proofs #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moodlezoup
force-pushed
the
feat/batched-opening-proofs
branch
from
40c6c72
to
6db5a96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For additively homomorphic commitment schemes (including Hyrax, Zeromorph, HyperKZG) we can use a sumcheck to reduce multiple opening proofs (multiple polynomials, not necessarily of the same size, each opened at a different point) into a single opening. This is implemented in Nova here.
In order to leverage this batching protocol while preserving the existing code architecture, we introduce opening "accumulators". Each time the prover computes an opening, where before it would compute the associated opening proof, the prover would now instead add the opening to the accumulator and defer the opening proof to the end. Similarly, each time the verifier encounters a claimed opening, instead of verifying the opening proof it instead adds the opening to its accumulator and defers the opening proof verification to the end.
This PR also includes significant refactoring (mostly related to memory-checking and R1CS/Spartan) with the intention of minimizing cloning and footguns (see issues below).
Closes #455, #382, #378, #377, and #317
EVM verifier needs to be updated to handle new batching protocol, will do in a follow-up PR