Parsing errors

[alittlecanarybird]

Hi!

First of all: thanks for creating this repository, it has saved me a lot of time!

Second: here is a couple of transactions that are being parsed wrong by the system (I suggest comparing the script output with Etherscan):

0x4d47350cc0912e292fb399c84d238156a1097c3589ca2bc47acb829989b97739
0x9058ad0eee3a29b8f407216a6c36d86ab6506876f663e1bcf9333176517be28a
0x47c6897e3de42585403e8ecd198c4211be05375f8cdc1fa636af6a5cab436611
0x4d47350cc0912e292fb399c84d238156a1097c3589ca2bc47acb829989b97739
0x0c67d461758c71799d52ea643190a4f43a091c66af5eba19f0aecccee30e0247

Best,
J

[dmatsuoka]

Thanks for your feedback! A few comments:

0x4d47350cc0912e292fb399c84d238156a1097c3589ca2bc47acb829989b97739
This transaction is associated with a "bundle trade" on Seaport, which is why it is excluded from the sales.csv output. The reason we exclude these transactions is because there is no way to determine a "price" associated with each of the NFT sales individually. However, the transfers will still show up in the transfers.csv output

0x0c67d461758c71799d52ea643190a4f43a091c66af5eba19f0aecccee30e0247
This transaction is associated with a "private sale" on Seaport, which is excluded from the sales.csv output. The reason we exclude these transactions is because the "price" of the sale can be misleading if it was not traded on the open market. However, the transfers will still show up in the transfers.csv output.

0x9058ad0eee3a29b8f407216a6c36d86ab6506876f663e1bcf9333176517be28a
0x47c6897e3de42585403e8ecd198c4211be05375f8cdc1fa636af6a5cab436611
These transactions are denominated in non-ETH/WETH currencies on the old Wyvern V2 contract, which is a known limitation that produces misleading outputs. Unfortunately, there is no easy to way decode this from the event logs alone...but I will look into a few potential solutions.