Skip to content
This repository has been archived by the owner on Mar 22, 2023. It is now read-only.

SCSS files in CSS folder #17

Closed
webelaine opened this issue Dec 19, 2022 · 3 comments
Closed

SCSS files in CSS folder #17

webelaine opened this issue Dec 19, 2022 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@webelaine
Copy link

  • The theme/assets/css/src folder contains SCSS files.
  • Are the cart and checkout files in this folder included by default, or are they just examples? Not all sites have a cart.
@otakupahp
Copy link

I agree, these files must be moved to SCSS folder (which should be names sass)

@Ninodevo Ninodevo self-assigned this Jan 11, 2023
@ahegyes
Copy link
Contributor

ahegyes commented Jan 11, 2023

The repo contains examples of doing all sorts of things that won't apply to every project. This is an example thereof.

The files under assets/scss (which we agreed in the task force meeting today should be renamed to sass) are meant to contain SASS files for compiling the theme's style.css. The files under assets/css are meant to be single-purpose CSS files to be enqueued on certain pages, or when a given block is present on the page (using the conditional has_block) or any other conditional and well-scoped scenario.

Ultimately, since these files are likely to be much smaller in scope, the assets/css folder might contain a few small CSS files directly. Or if one wants to use SASS, we recommend the current structure of a src and a build folder to follow the same structure as webpack (used for the Gutenberg blocks and for compiling JS/TS files) for consistency.

@tommusrhodus tommusrhodus added the documentation Improvements or additions to documentation label Feb 8, 2023
@ahegyes
Copy link
Contributor

ahegyes commented Feb 22, 2023

This has been answered more in-depth in these two README FAQs:

@ahegyes ahegyes closed this as completed Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

5 participants