Skip to content
This repository has been archived by the owner on Mar 22, 2023. It is now read-only.

WC opt-in #19

Closed
webelaine opened this issue Dec 19, 2022 · 4 comments
Closed

WC opt-in #19

webelaine opened this issue Dec 19, 2022 · 4 comments
Labels
documentation Improvements or additions to documentation wontfix This will not be worked on

Comments

@webelaine
Copy link

The WooCommerce Usage auto-opt-in feels a little awkward. I can see why it would be desirable to always opt into usage tracking for sites that use Woo, but not all sites do. Maybe this could be a recommended plugin but not always bundled?

@georgestephanis
Copy link

Previous discussion on the topic:

Automattic/team51-cli#102 (comment)

@ahegyes
Copy link
Contributor

ahegyes commented Jan 11, 2023

Per the discussion linked by @georgestephanis above, I think the submodule should stay in the default project since we can never be sure if a website will include the plugin later on or not. Moreover, the naming of the repo isn't very accurate anymore since it also opts into Sensei tracking (and might be enhanced in the future again).

Ultimately, this project is meant to represent a default and an example for all sorts of scenarios that might not apply to all websites. If it's painfully clear that the WC opt-in submodule will never, ever apply to a site, then it should be fine to remove for said project :)

@webelaine
Copy link
Author

I don't know if there's a way to add options for a default project, but something similar to the Foundation framework, where you can select just the components you need and it bundles those for you to use on your project, would be extra awesome. I can understand how if there is no similar Git functionality, all the common components would need to be included.

@tommusrhodus tommusrhodus added documentation Improvements or additions to documentation wontfix This will not be worked on labels Feb 8, 2023
@ahegyes
Copy link
Contributor

ahegyes commented Feb 22, 2023

I've added the reasoning for this in the README. For now, the module should remain auto-included as long as the partner doesn't explicitly ask us against it.

I don't know if there's a way to add options for a default project, but something similar to the Foundation framework, where you can select just the components you need and it bundles those for you to use on your project, would be extra awesome. I can understand how if there is no similar Git functionality, all the common components would need to be included.

I agree but it's kind of out-of-scope for this project 😅 If this becomes popular enough though, I don't see why that couldn't be included in the future 😄

@ahegyes ahegyes closed this as completed Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants