-
Notifications
You must be signed in to change notification settings - Fork 2
WC opt-in #19
Comments
Previous discussion on the topic: |
Per the discussion linked by @georgestephanis above, I think the submodule should stay in the default project since we can never be sure if a website will include the plugin later on or not. Moreover, the naming of the repo isn't very accurate anymore since it also opts into Sensei tracking (and might be enhanced in the future again). Ultimately, this project is meant to represent a default and an example for all sorts of scenarios that might not apply to all websites. If it's painfully clear that the WC opt-in submodule will never, ever apply to a site, then it should be fine to remove for said project :) |
I don't know if there's a way to add options for a default project, but something similar to the Foundation framework, where you can select just the components you need and it bundles those for you to use on your project, would be extra awesome. I can understand how if there is no similar Git functionality, all the common components would need to be included. |
I've added the reasoning for this in the README. For now, the module should remain auto-included as long as the partner doesn't explicitly ask us against it.
I agree but it's kind of out-of-scope for this project 😅 If this becomes popular enough though, I don't see why that couldn't be included in the future 😄 |
The WooCommerce Usage auto-opt-in feels a little awkward. I can see why it would be desirable to always opt into usage tracking for sites that use Woo, but not all sites do. Maybe this could be a recommended plugin but not always bundled?
The text was updated successfully, but these errors were encountered: