Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: the rias plugin doesn't support {height} #214

Closed
LRancez opened this issue Jan 12, 2016 · 1 comment
Closed

enhancement: the rias plugin doesn't support {height} #214

LRancez opened this issue Jan 12, 2016 · 1 comment

Comments

@LRancez
Copy link
Contributor

LRancez commented Jan 12, 2016

Hi there,
I really like lazysizes. Great work, thanks for sharing!
But the rias plugin don't currently work with the {height} replacement.
Some automated resize systems require the height. Besides, it will be very useful for applying automated cropping. I needed this {height} to make cool crops with thumbor, for example.
So I'd made a PR with the needed changes: #213

So far is working good, but don't hesitate in let me know if you have any improvements to that code.
Best,

Lucas

@LRancez
Copy link
Contributor Author

LRancez commented Jan 20, 2016

Done: #213

@LRancez LRancez closed this as completed Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant